Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): provide parseContent #271

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Sep 8, 2023

What?

This PR fixes the Container and the Demo, and now all the CI tasks are passing in this stack of PRs.

Why?

JIRA: EXT-1959

How to test? (optional)

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 3:06pm

@eunjae-lee
Copy link
Contributor Author

@eunjae-lee eunjae-lee marked this pull request as ready for review September 11, 2023 09:58
@eunjae-lee eunjae-lee requested review from a team and BibiSebi and removed request for a team September 11, 2023 09:59
Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking goood :) the only thing that i have a bit struggle understanding is the typescript satisfies operator because i havent really used it but i wil check it out

@eunjae-lee
Copy link
Contributor Author

Looking goood :) the only thing that i have a bit struggle understanding is the typescript satisfies operator because i havent really used it but i wil check it out

neither have I ! I read about it before but don't remember it (and that code is actually from Johannes)

@BibiSebi BibiSebi force-pushed the EXT-1958-helper-update-vue-2-helper branch from b9f08cc to c845c64 Compare September 12, 2023 14:40
@BibiSebi BibiSebi force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from b17c775 to b4dd69d Compare September 12, 2023 14:40
@eunjae-lee eunjae-lee force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch 2 times, most recently from f6e3657 to c4a8b0b Compare September 13, 2023 08:55
@BibiSebi BibiSebi force-pushed the EXT-1958-helper-update-vue-2-helper branch from 61be914 to 9bdda33 Compare September 13, 2023 09:07
@BibiSebi BibiSebi force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from c4a8b0b to 962e02f Compare September 13, 2023 09:07
@eunjae-lee eunjae-lee force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from 962e02f to c595968 Compare September 13, 2023 15:43
@eunjae-lee eunjae-lee force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from c595968 to 06e4b96 Compare September 13, 2023 15:44
@BibiSebi BibiSebi force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from 06e4b96 to ca8b869 Compare September 14, 2023 09:46
@eunjae-lee
Copy link
Contributor Author

eunjae-lee commented Sep 14, 2023

Merge Activity

  • Sep 14, 10:27 AM: @eunjae-lee started a stack merge that includes this pull request via Graphite.
  • Sep 14, 10:28 AM: Graphite failed to merge this pull request due to internal failures. Try your merge again, or report a bug if you see this consistently.
  • Sep 14, 10:39 AM: @eunjae-lee started a stack merge that includes this pull request via Graphite.
  • Sep 14, 10:39 AM: Graphite couldn't merge this pull request because a downstack PR fix(helper): update vue3 helper #269 failed to merge.

@eunjae-lee eunjae-lee force-pushed the EXT-1958-helper-update-vue-2-helper branch from d02944d to 111b0e0 Compare September 14, 2023 14:55
Base automatically changed from EXT-1958-helper-update-vue-2-helper to main September 14, 2023 14:55
@eunjae-lee eunjae-lee force-pushed the EXT-1959-demo-fix-demo-regarding-the-library-changes branch from ca8b869 to aba14d4 Compare September 14, 2023 14:56
@eunjae-lee eunjae-lee merged commit 1e1b0e5 into main Sep 14, 2023
17 of 18 checks passed
@eunjae-lee eunjae-lee deleted the EXT-1959-demo-fix-demo-regarding-the-library-changes branch September 14, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants